[Bug 793704] srtpenc/srtpdec force application/x-srtp even when encryption disabled

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793704

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368731|none                        |needs-work
             status|                            |

--- Comment #1 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 368731:
 --> (https://bugzilla.gnome.org/review?bug=793704&attachment=368731)

::: ext/srtp/gstsrtpdec.c
@@ +168,3 @@
     GST_PAD_SINK,
     GST_PAD_ALWAYS,
+    GST_STATIC_CAPS ("application/x-srtcp;application;x-rtcp")

it's application/x-rtcp
Also, add a space after the ";" for readability

@@ +945,2 @@
         GstStructure *ps = gst_caps_get_structure (ret, i);
+    if (0) {

The if(0) here is clearly wrong!

And, I'm pretty sure the way this is done here is wrong.. We now need to
duplicate all the structure and set the first version to x-srt{c,}p and leave
the second copy as-is.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.