[Bug 606643] isomp4: closed captions support (muxing and demuxing)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=606643

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367985|none                        |accepted-commit_after_freez
             status|                            |e

--- Comment #8 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 367985:
 --> (https://bugzilla.gnome.org/review?bug=606643&attachment=367985)

Looks good, have a question/optimisation, but I doubt it really relevant.

::: gst/isomp4/qtdemux.c
@@ +5427,3 @@
+    gst_buffer_unref (buf);
+    if (cc) {
+      buf = _gst_buffer_new_wrapped (cc, cclen, g_free);

Couldn't we sub-buffer this instead of copying ? (i.e. buffer_copy()
buffer_resize())

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.