[Bug 792378] qmlglsink: make work with eglfs_kms

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792378

--- Comment #5 from Carlos Rafael Giani <dv at pseudoterminal.org> ---
In the comments for bug 783521, there was this response by Matthew:


::: ext/qt/gstqtglutility.cc
@@ +122,3 @@
+    EGLDisplay egl_display = (EGLDisplay)
+        native->nativeResourceForWindow("egldisplay", NULL);
+    display = (GstGLDisplay *) gst_gl_display_egl_new_with_egl_display
(egl_display);

What if egl_display is invalid?

Also, this code will always be run when libgstgl is GST_GL_HAVE_WINDOW_GBM
enabled and realistically, could probably replace the next #else cause so you
don't need to #elif GST_GL_HAVE_WINDOW_GBM.


I added a check to see if egl_display is EGL_NO_DISPLAY, but beyond that, it is
actually unclear to me what to do if there's no valid egl_display. The code
does not indicate error handling for that. I also do not understand the comment
about #else - removing that part seems erroneous, since it looks like a
"generic EGL fallback"...?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.