[Bug 793412] msdk: session close failure if there are multiple sessions in a pipeline

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793412

sreerenj <bsreerenj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368816|none                        |reviewed
             status|                            |

--- Comment #2 from sreerenj <bsreerenj at gmail.com> ---
Review of attachment 368816:
 --> (https://bugzilla.gnome.org/review?bug=793412&attachment=368816)

::: sys/msdk/gstmsdkcontext.c
@@ +216,3 @@
+{
+  mfxSession _session = session;
+  MFXDisjoinSession (_session);

Ideally, it should make sure there is no active task.
According to spec, if this API returns MFX_WRN_IN_EXECUTION:
"Active tasks are in execution or in queue. Wait for
the completion of the tasks and then call this
function again."

@@ +292,3 @@
   priv->job_type = parent_priv->job_type;
+  parent_priv->child_session_list =
+      g_list_append (parent_priv->child_session_list, priv->session);

It is recommended to use g_list_prepend whenever possible.
https://developer.gnome.org/glib/stable/glib-Doubly-Linked-Lists.html#g-list-append

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.