[Bug 793708] msdk: dec: memleaks when flushing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793708

sreerenj <bsreerenj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368737|none                        |reviewed
             status|                            |

--- Comment #3 from sreerenj <bsreerenj at gmail.com> ---
Review of attachment 368737:
 --> (https://bugzilla.gnome.org/review?bug=793708&attachment=368737)

::: sys/msdk/gstmsdkdec.c
@@ +947,3 @@
   for (i = 0; i < thiz->tasks->len; i++) {
     task = &g_array_index (thiz->tasks, MsdkDecTask, thiz->next_task);
+    gst_msdkdec_finish_task (thiz, task);

Why remove the return value checking?
Assume that the finish_frame returns error due to flushing, in this case, you
are not supposed to send a queued task/frame again. right?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.