[Bug 793413] msdk: manage mfxFrameSurfaces seperately with other surfacepool.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793413

sreerenj <bsreerenj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368614|none                        |reviewed
             status|                            |

--- Comment #3 from sreerenj <bsreerenj at gmail.com> ---
Review of attachment 368614:
 --> (https://bugzilla.gnome.org/review?bug=793413&attachment=368614)

Overall looks good to me. One question,
Why can't we just release the buffer back to pool (within the custom
acquire_buffer method)if it is locked by msdk? Is there any particular reason
for keeping available & used surfaces in lists?

::: sys/msdk/gstmsdkcontext.c
@@ +466,3 @@
+          g_list_remove (msdk_resp->surfaces_avail, surface);
+      msdk_resp->surfaces_used =
+mfxFrameSurface1 *

It is recommended to use g_list_prepend instead of g_list_append().

::: sys/msdk/gstmsdkvideomemory.c
@@ +60,3 @@
   return surface;
 }


Add some comments here, please.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.