[Bug 793776] rtspclientsink: allow setting payloader as pad property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793776

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368887|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 368887:
 --> (https://bugzilla.gnome.org/review?bug=793776&attachment=368887)

::: gst/rtsp-sink/gstrtspclientsink.c
@@ +184,3 @@
+      g_param_spec_string ("payloader", "payloader factory name",
+          "The name of the payloader factory to use", NULL,
+          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

Why as a string? We could take an actual element (gst-launch has some magic to
allow any parse-launch string then) here instead

@@ +1283,3 @@
+        /* User-specified payloader, which we haven't constructed yet,
+         * caps could be any */
+        caps = gst_caps_new_any ();

Then this could also take the caps :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.