[Bug 793829] vaapih264enc: keyframe-perdiod incongruence between declaration and description

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793829

--- Comment #1 from Matteo Valdina <matteo.valdina at gmail.com> ---
Created attachment 368915
  --> https://bugzilla.gnome.org/attachment.cgi?id=368915&action=edit
Patch for include to zero the periodic key frame.

Added a patch for extend to zero the valid range of keyframe-period.

Tested with this script:

~~~
#!/bin/bash

KEYFRAME_PERIOD=0
# generate a test stream.
gst-launch-1.0 videotestsrc pattern=18 num-buffers=300 ! \
              video/x-raw,framerate=15/1 ! \
              vaapih264enc keyframe-period=$KEYFRAME_PERIOD ! \
              video/x-h264,profile=baseline ! \
              filesink location=test.h264


ffprobe -select_streams v -show_frames -show_entries frame=pict_type test.h264
| grep pict_type > report.log


echo "I-frame $(cat report.log | grep I | wc -l)"
echo "P-frame $(cat report.log | grep P | wc -l)"

~~~

Changing the value of frame rate the ratio of I-frame/P-frame was the expected
(1 frame each second).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.