[Bug 793820] Implement paste functionality within GESTimeline class
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Feb 26 11:00:30 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=793820
--- Comment #4 from Harish Fulara <harish14143 at iiitd.ac.in> ---
(In reply to Thibault Saunier from comment #2)
> Review of attachment 368906 [details] [review]:
>
> Looks almost all right :-)
>
> ::: ges/ges-timeline-element.h
> @@ -138,2 +138,4 @@
> GESTimeline *timeline;
> gchar *name;
> + /* For copy-paste operation */
> + GESTimelineElement *copied_from;
>
> This break the ABI (it would require to add `gpointer
> _ges_reserved[GES_PADDING_LARGE -1];` in the same structure), but you should
> rather had an internal method to get it as I do not think that should be API
>
> Made the appropriate changes.
>
> ::: ges/ges-timeline.h
> @@ -159,2 +159,4 @@
> GST_EXPORT
> gboolean ges_timeline_is_empty (GESTimeline * timeline);
> +GST_EXPORT
> +GESTimelineElement * ges_timeline_paste (GESTimeline * timeline,
>
> I would call it `ges_timeline_paste_elemt`.
> Renamed function to 'ges_timeline_paste_element'
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list