[Bug 793820] Implement paste functionality within GESTimeline class

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Feb 26 15:56:55 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793820

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368951|none                        |needs-work
             status|                            |

--- Comment #7 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 368951:
 --> (https://bugzilla.gnome.org/review?bug=793820&attachment=368951)

::: ges/ges-timeline.c
@@ +3782,3 @@
+  res = element_class->paste (element, copied_from, paste_position);
+
+  g_clear_object (&copied_from);

You do not own the reference here, GESTimelineElement does, you will need to
add a way to clean that ref, I guess we can state that
ges_timeline_element_get_copied_from gives it reference and sets it back to
NULL (ie. in that method result priv->copied_from to NULL).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list