[Bug 782923] gl: Add Mesa3D GBM backend

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=782923

--- Comment #20 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Matthew Waters (ystreet00) from comment #17)
> Review of attachment 368862 [details] [review]:
> 
> One nit.
> 
> ::: m4/gst-gl.m4
> @@ +481,3 @@
> +        HAVE_WINDOW_GBM=yes
> +        GL_LIBS="$GL_LIBS"
> +        GL_CFLAGS="$GL_CFLAGS"
> 
> This seems redundant, no?

Oops, I saw it and forgot to remove. I'll fix.

(In reply to Matthew Waters (ystreet00) from comment #18)
> Review of attachment 368864 [details] [review]:
> 
> Not quite :)
> 
> ::: gst-libs/gst/gl/meson.build
> @@ +603,3 @@
>  endif
>  
> +# GDM Checks
> 
> GBM
> 
> @@ +708,3 @@
>    install_headers(gl_x11_headers, subdir : 'gstreamer-1.0/gst/gl/x11')
>    install_headers(gl_wayland_headers, subdir :
> 'gstreamer-1.0/gst/gl/wayland')
> +  install_headers(gl_gbm_headers, subdir : 'gstreamer-1.0/gst/gl/gbm')
> 
> This header is not installed in the autotools build.

Ok, I'll check which one is right and fix. I've just followed a pattern here
without thinking through.

(In reply to Matthew Waters (ystreet00) from comment #19)
> https://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/
> ?id=ee5953765783fa6969e744c448660c010277853f should also be solved like
> every other winsys by adding DRM_CFLAGS to GL_CFLAGS in m4/gst-gl.m4.

Ok.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.