[Bug 793441] rtsp-stream: client transport is not updated for multicast clients

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 28 08:58:39 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793441

--- Comment #31 from Patricia Muscalu <patricia at axis.com> ---
(In reply to Sebastian Dröge (slomo) from comment #30)
> (In reply to Patricia Muscalu from comment #27)
> > (In reply to Sebastian Dröge (slomo) from comment #25)
> > > Comment on attachment 369083 [details] [review] [review] [review]
> > > Corrected logic in check_mcast_part_for_transport
> > > 
> > > Why is this stored as a GString instead of storing it as an array/list of
> > > address/ports?
> > > 
> > > Also please explain in the commit message what exactly this is fixing
> > 
> > Inspired by PROP_CLIENTS in gstmultiudpsink.
> 
> That's because there it is a GObject property. Here we have proper C API and
> can make use more better types :) That would also make the strstr()
> unnecessary that is currently there to check if client is there, and makes
> it easier to remove a client.

Yes, good point. We should have a list of addresses instead. Ok with GList?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list