[Bug 793917] New: audioaggregator: Conversion API is confusing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793917

            Bug ID: 793917
           Summary: audioaggregator: Conversion API is confusing
    Classification: Platform
           Product: GStreamer
           Version: unspecified
                OS: Linux
            Status: NEW
          Severity: blocker
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: slomo at coaxion.net
        QA Contact: gstreamer-bugs at lists.freedesktop.org
                CC: mduponchelle1 at gmail.com, olivier.crete at ocrete.ca
     GNOME version: ---

Currently audioaggregator always does conversion by default for the sinkpads
and srcpad. Disabling this would require the convert_buffer vfunc to be NULL,
which is what audiointerleave does.

In addition there is a GstAudioAggregatorConvertPad type. Using it does not
decide whether conversion is possible, it only a) caches the converter (it is
otherwise recreated for each buffer!) and b) provides a property to set the
converter parameters.


To clear up this confusion I would propose the following:
1) Conversion is only decided by the existence of convert_buffer, and by
default that's exactly what it does
2) GstAudioAggregatorPad already caches the converter, and equally a converter
is cached for the srcpad. It makes no sense to recreate it all the time (but it
should be flushed correctly when needed)
3) Let GstAudioAggregatorConvertPad only be there for the property. If you want
the default conversion behaviour and the property, use that pad type. Otherwise
not.


Thoughts?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.