[Bug 792034] dmabuf import with icamerasrc plugin does not working with gst-vaapi-1.12.2

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792034

--- Comment #9 from renwei.wu at intel.com ---
(In reply to sreerenj from comment #1)
> We should remove the super hack in gstremaer-vaapi which is to support the
> dmabuf export from vaapi element to upstream (eg: gst-launch-1.0 v4l2src
> io-mode=dmabuf-import ! vaapipostproc format=nv12 ! fakesink):
> https://cgit.freedesktop.org/gstreamer/gstreamer-vaapi/tree/gst/vaapi/
> gstvaapipluginbase.c#n425
> 
> We had some discussion regarding the same:
> https://bugzilla.gnome.org/show_bug.cgi?id=765435#c7
> 
> Not sure whether v4l2src already implemented it, I guess not.
> 
> BTW, IIUC regression is not because of gstreamer-vaapi code, but because of
> icamerasrc changes, right?

(In reply to sreerenj from comment #1)
> We should remove the super hack in gstremaer-vaapi which is to support the
> dmabuf export from vaapi element to upstream (eg: gst-launch-1.0 v4l2src
> io-mode=dmabuf-import ! vaapipostproc format=nv12 ! fakesink):
> https://cgit.freedesktop.org/gstreamer/gstreamer-vaapi/tree/gst/vaapi/
> gstvaapipluginbase.c#n425
> 
> We had some discussion regarding the same:
> https://bugzilla.gnome.org/show_bug.cgi?id=765435#c7
> 
> Not sure whether v4l2src already implemented it, I guess not.
> 
> BTW, IIUC regression is not because of gstreamer-vaapi code, but because of
> icamerasrc changes, right?

(In reply to sreerenj from comment #1)
> We should remove the super hack in gstremaer-vaapi which is to support the
> dmabuf export from vaapi element to upstream (eg: gst-launch-1.0 v4l2src
> io-mode=dmabuf-import ! vaapipostproc format=nv12 ! fakesink):
> https://cgit.freedesktop.org/gstreamer/gstreamer-vaapi/tree/gst/vaapi/
> gstvaapipluginbase.c#n425
> 
> We had some discussion regarding the same:
> https://bugzilla.gnome.org/show_bug.cgi?id=765435#c7
> 
> Not sure whether v4l2src already implemented it, I guess not.
> 
> BTW, IIUC regression is not because of gstreamer-vaapi code, but because of
> icamerasrc changes, right?

Can't simply say it caused by icamerasrc change. The icamerasrc is only
validated on certain version of gstreamer like 1.8.3. For about one year, the
gstreamer version stays on this version. And we do the upgrade gstreamer
version to 1.12.2, the issue is captured.
Go back to check the history, we found 
1 code refactoring in icamerasrc to support multi streams and icamerasrc is not
inherited from PUSHSRC.
2 vaapi remove the option GST_BUFFER_POOL_OPTION_DMABUF_MEMORY.

Now it becomes the allocator and pool is empty when using the dmabuf import.

Since the memory:dmabuf is still in development. I suggest to still add the
hack in vappi for icamerasrc to enable the dmabuf import.

When the memory:dmabuf filter is enabled, the hack can be removed throughly.

A hack of hack patch is attached.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.