[Bug 792260] msdk: decode: Add mpeg2 decoder

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792260

--- Comment #6 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #5)
> (In reply to sreerenj from comment #3)
> > (In reply to Sebastian Dröge (slomo) from comment #2)
> > > Review of attachment 366403 [details] [review] [review] [review]:
> > > 
> > > ::: sys/msdk/gstmsdkmpeg2dec.c
> > > @@ +48,3 @@
> > > +        "framerate = (fraction) [0/1, MAX], "
> > > +        "width = (int) [ 1, MAX ], height = (int) [ 1, MAX ], "
> > > +        "mpegversion = 2")
> > > 
> > > This probably also handles mpegversion=1 or not?
> > 
> > NO, Only version 2.
> 
> That would be quite surprising. Did you try? MPEG1 is approximately a subset
> of MPEG2.

I haven't tried. But at least MSDK spec only advertising MFX_CODEC_MPEG2
Is it the exact subset? I don't think so, but may be I am mistaken. I don't
remember exactly, but there were mpeg1 streams which weren't working correctly
with gstreamer-vaapi.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.