[Bug 792597] New: GL: fix leak of elements requested by signals

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792597

            Bug ID: 792597
           Summary: GL: fix leak of elements requested by signals
    Classification: Platform
           Product: GStreamer
           Version: unspecified
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: slomo at coaxion.net
        QA Contact: gstreamer-bugs at lists.freedesktop.org
                CC: mduponchelle1 at gmail.com, slomo at coaxion.net,
                    ystreet00 at gmail.com
     GNOME version: ---

+++ This bug was initially created as a clone of Bug #792543 +++

When the signal returns a floating reference, as its return type
is transfer full, we need to sink it ourselves before passing
it to gst_bin_add (which is transfer floating).

This allows us to unref it in bin_remove_element later on, and
thus to also release the reference we now own if the signal
returns a non-floating reference as well.

As we now still hold a reference to the element when removing it,
we also need to lock its state and setting it to NULL before
unreffing it


This relates to all the "create-element" signals that various GL elements have.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.