[Bug 789358] playbin: Memory not freed in failure case in gst_playback_utils_get_n_common_capsfeatures()

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jan 17 11:59:56 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=789358

--- Comment #8 from Ashish Kumar <kr.ashish at samsung.com> ---
Because
control goes inside :

if (!fact1_tmpl_caps || !fact2_tmpl_caps) {
...
}

only if at least one of 'fact1_tmpl_caps' and 'fact2_tmpl_caps' is missing.

Inside if clause
if 
'if (fact1_tmpl_caps)' is true then
'if (fact2_tmpl_caps)' has to be false and vice versa.

So we need not to check for both. If both fact1_tmpl_caps and fact2_tmpl_caps 
are defined the control will not go inside :
if (!fact1_tmpl_caps || !fact2_tmpl_caps) {
...
}

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list