[Bug 792645] New: basetransform: set_passthrough() not doing what the doc says

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792645

            Bug ID: 792645
           Summary: basetransform: set_passthrough() not doing what the
                    doc says
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: nicolas at ndufresne.ca
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

The doc says:

 * Always %TRUE for filters which don't implement either a transform
 * or transform_ip method.

While the implementation is no-op in the case we pass FALSE and that conditions
is met:

  >if (!passthrough) {
  >  if (bclass->transform_ip || bclass->transform)
  >    trans->priv->passthrough = FALSE;
  >} else {
  >  trans->priv->passthrough = TRUE;
  >}

It's also a weird condition to check for filters that only wants to implement
submit_input_buffer() and generate_output(), as they need to place a useless
stub for one of the transform function in order to make it behave properly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.