[Bug 788550] test-egl: g_assert_not_reached called incorrectly in function handle_queued_objects

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jan 18 23:11:24 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=788550

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #360952|none                        |needs-work
             status|                            |

--- Comment #4 from Julien Isorce <julien.isorce at gmail.com> ---
Review of attachment 360952:
 --> (https://bugzilla.gnome.org/review?bug=788550&attachment=360952)

::: gst-omx-1.12.3_org/examples/egl/testegl.c
@@ +941,1 @@


Thx for the patch. Please remove the whole block "else if (GST_IS_QUERY
(object)) {". It should have been removed by this commit
https://cgit.freedesktop.org/gstreamer/gst-omx/commit/examples/egl/testegl.c?id=f1c76ef92112acc7855d5715ac149a3620559f6a
, my mistake. Indeed the function "queue_object" does not queue any query
anymore.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list