[Bug 792680] qtmux: Make sure timecode uses the same timescale as video

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792680

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367079|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 367079:
 --> (https://bugzilla.gnome.org/review?bug=792680&attachment=367079)

::: gst/isomp4/gstqtmux.c
@@ +2591,3 @@

+        atom_trak_set_timecode_type (qpad->tc_trak, qtmux->context,
+            gst_qt_mux_pad_get_timescale (qtpad), tc);

You should take the actually configured timescale here from
qpad->trak_ste->mdia.mdhd.time_info.timescale or so.

It might be configured via the pad property, via the muxer property, or taken
from the framerate. That decision was done already and stored in the qpad.

@@ +4092,3 @@

+    atom_trak_set_timecode_type (pad->tc_trak, qtmux->context,
+        gst_qt_mux_pad_get_timescale (qtpad), pad->first_tc);

Same here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.