[Bug 783418] audioconvert: Fix memory leak in test code failure path

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jan 19 18:52:54 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=783418

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.13.1
            Summary|audioconvert: Fix memory    |audioconvert: Fix memory
                   |leak in test code           |leak in test code failure
                   |                            |path

--- Comment #9 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Ok, I have pushed another solution (in your name, hope you don't mind) that is
simpler:

commit 4876fe04f589189db697b5a2e669901a9eb614ee
Author: Jimmy Ohn <yongjin.ohn at lge.com>
Date:   Mon Jun 5 14:08:33 2017 +0900

    tests: audioconvert: Fix memory leak in failure path

    Don't set a bad example by leaking things, even if calling
    g_error() will make the process abort.

    https://bugzilla.gnome.org/show_bug.cgi?id=783418

But in general these are unit tests and we are not going to clean up stuff when
they fail/abort, so this commit is more of an exception really :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list