[Bug 792711] New: gdp (GStreamer Data Protocol) doesn't support GST_EVENT_CUSTOM event types.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792711

            Bug ID: 792711
           Summary: gdp (GStreamer Data Protocol) doesn't support
                    GST_EVENT_CUSTOM event types.
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: mgruenke at tycoint.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Refer to gstreamer/gst/gstevent.h, where all CUSTOM event types have a
GstEventType >= (270 << 8).  This always results in values greater than 2^16,
yet we see from gst-plugins-bad/gst/gdp/dataprotocol.c that
gst_dp_event_from_packet_1_0() reads the GstEventType using
GST_DP_HEADER_PAYLOAD_TYPE(), which is defined as GST_READ_UINT16_BE(). 
Consequently, any GST_EVENT_CUSTOM will deserialize with a bad type.

I'm not very familiar with dataprotocol, but it's not clear to me how this can
be resolved without incrementing the dataprotocol version.

In future revisions of the protocol, I would suggest that serialization of any
enums support values up to 32-bits.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.