[Bug 792680] qtmux: Make sure timecode uses the same timescale as video

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792680

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367310|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 367310:
 --> (https://bugzilla.gnome.org/review?bug=792680&attachment=367310)

Looks good except for one thing

::: gst/isomp4/atoms.c
@@ +3825,3 @@
   trak->mdia.mdhd.time_info.timescale =
+      trak_timescale !=
+      0 ? trak_timescale : atom_framerate_to_timescale (tc->config.fps_n,

This can never be 0, can it?

@@ +3837,3 @@
   tmcd->timescale =
+      trak_timescale !=
+      0 ? trak_timescale : atom_framerate_to_timescale (tc->config.fps_n,

This can never be 0, can it?

@@ +3839,3 @@
+      0 ? trak_timescale : atom_framerate_to_timescale (tc->config.fps_n,
+      tc->config.fps_d);
+  tmcd->frame_duration = tmcd->timescale * tc->config.fps_d /
tc->config.fps_n;

You probably want to use gst_util_uint64_scale_int() here, just in case
timescale and fps_d are both rather big.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.