[Bug 792798] video-overlay: Add helper to make render rectangle controllable with properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792798

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Oh, I didn't correct Sebastian on the atomicity claim, the previous
implementation was atomic if use the right way, just read a little more the
code, it will call set_render_rectangle() once when the property groups have
been set (using dispatch_properties_changed virtual). This virtual is called
once per group of property being set, that is when multiple property are set
within the same call to g_object_set() or if g_object_set() is recursively
calling itself.

I'll go a new version now with single property, since this removes all this
complexity for atomicity and having to store the rectangle meanwhile.

(In reply to Tim-Philipp Müller from comment #8)
> Could probably also do a new interface
> (GstVideoOverlayPropertySetterCommandLinethingy) that provides these
> properties and depends on the GstVideoOverlay interface. That way we can add
> properties without breaking backwards compat. But it's also not very nice :)

Sure, but then if you want to add another property later you have to create yet
another interface, it's a bit crazy.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.