[Bug 791986] aggregator: add a drain vmethod

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791986

Mathieu Duponchelle <mduponchelle1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #366042|none                        |needs-work
             status|                            |

--- Comment #16 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 366042:
 --> (https://bugzilla.gnome.org/review?bug=791986&attachment=366042)

Looks good to me, I assume the test suites still work?

Needs an actual commit message too :)

::: libs/gst/base/gstaggregator.c
@@ +1934,3 @@
       /* don't pass it along as some (file)sink might claim it does
        * whereas with a collectpads in between that will not likely work */
+      // FIXME: wat?    ^^^^^^^^^^^

This comes from cc216208233f44b2df689665c58a2365ccc3e286, the explanation in
the commit makes a bit more sense:

    collectpads2: provide query default and callback handling

    ... which presently mainly serves to answer SEEKING query negatively
    to dissuade upstream encoders from doing any seeking and
    "header finalization" (since the returned result of pushing a
    sticky event is fairly useless nowadays).

However that seems pretty fishy to me, we should probably instead either let
muxer subclasses do that themselves, or provide some API

@@ +2073,3 @@
   priv->segmented_seeking = segmented;
+  /* we apply the segment, once we have segment from all sources */
+  /* FIXME: do we need a queue of seek-events? */

I suppose this FIXME can be removed as long as we don't need to support
non-flushing segment seeks followed by non flushing segmented seeks

-- 
You are receiving this mail because:
You are the QA Contact for the bug.