[Bug 757563] audiomixer: issues with seamless looping (missing support for non-flushing seeks)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757563

Mathieu Duponchelle <mduponchelle1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #366010|none                        |needs-work
             status|                            |

--- Comment #24 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 366010:
 --> (https://bugzilla.gnome.org/review?bug=757563&attachment=366010)

Some comments, I also wonder the same thing as Olivier. Second part of the
commit message should also be edited out :)

::: gst-libs/gst/audio/gstaudioaggregator.c
@@ +1732,2 @@
   /* Update position from the segment start/stop if needed */
+  if (agg->segment.position == -1 || agg->segment.position <
agg->segment.start) {

How can this happen?

@@ +1999,3 @@
+      /* when using live sources, we might get output_offset to be offset + 1
+       * due to rounding errors (?), clip the max_offset to the segment
+       */

That seems unrelated, and I'm not sure I understand how this can happen, I
think it'd better be discussed in a separate issue.

@@ +2049,3 @@
   /* send it out */
   GST_LOG_OBJECT (aagg,
+      "pushing outbuf %p, timestamp %" GST_TIME_FORMAT ", offset %"

Could be simplified by just using GST_PTR_FORMAT + the offset instead

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.