[Bug 791838] netsim: fix misleading packet delay log
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Jan 24 00:26:44 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=791838
Tim-Philipp Müller <t.i.m at zen.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|git master |1.13.1
--- Comment #9 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Pushed this, thanks for the patch and sorry for the nonsensical review, I have
no idea what I was thinking!
commit 3f87a9dd7f629f02ad6c76ee7bdd213ac5409322
Author: Jun Xie <jun.xie at samsung.com>
Date: Thu Dec 21 18:33:49 2017 +0800
netsim: fix misleading packet delay log
packet delay time shall be calculated by ready_time minus current time
https://bugzilla.gnome.org/show_bug.cgi?id=791838
---
Regarding the other questions:
1) FLUSH_START,STOP: yes, we should probably clear any pending delayed
packets/sources on FLUSH_STOP. Feel free to open a separate bug for that and/or
make a patch for that.
2) Not dropping packets when max-kbps is maxed out: I'm guessing the current
behaviour is to simulate a UDP-like scenario. I'd say let's open another bug
for this if this is something you want to pursue.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list