[Bug 792899] gstreamer-sharp doesn't free string

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792899

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367421|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 367421:
 --> (https://bugzilla.gnome.org/review?bug=792899&attachment=367421)

::: sources/custom/Application.cs
@@ +51,3 @@
             gst_init(ref cnt_argv, ref native_argv);
+            for (int i = 0; i < cnt_argv; i++)
+                GLib.Marshaller.Free (native_argv[i]);

While this is correct, this is not enough.

gst_init() can change the array, it removes all arguments that it handled
itself. So you would be leaking those ones here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.