[Bug 792782] directsoundsink/src: Add support for a DeviceProvider

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792782

--- Comment #5 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
Review of attachment 367389:
 --> (https://bugzilla.gnome.org/review?bug=792782&attachment=367389)

LGTM, just a few minor comments.

::: sys/directsound/gstdirectsounddevice.c
@@ +103,3 @@
+      "audio/x-ac3, framed = (boolean) true;"
+      "audio/x-dts, framed = (boolean) true;");
+#endif

Maybe it makes sense to factor this out into gstdirectsoundsink.h as a string
macro instead of duplicating it? Ditto for gstdirectsoundsrc.h.

@@ +124,3 @@
+  GST_INFO_OBJECT (probe_data->self, "sound device name: %s, %s (GUID %s)",
+      description, driver, guid_str);
+

GST_STR_NULL (guid_str) ?

@@ +140,3 @@
+      "device-class", "Audio/Sink", "properties", props, NULL);
+#endif
+

If you want to be fancy, you can #ifdef only "Audio/Source" and "Audio/Sink" ;)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.