[Bug 771853] subparse: Last string isn't displayed when srt subtitles lack a blank line at the end

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771853

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.13.1

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Found a solution after all:

commit 3219b704fd6a6f24daef5a66e9251ae2e159a4cc (HEAD -> master)
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Thu Jan 25 18:39:11 2018 +0000

    subparse: fix pushing out of last chunk if last line has no newline

    With playbin the last subtitle chunk would not get displayed
    if the last chunk was missing a newline at the end. This is
    because streamsynchronizer will hold back the EOS event until
    the audio and video streams are finished too, so subparse
    would never forcefully push out the last chunk until the very
    end when it is too late.

    We get a STREAM_GROUP_DONE event from streamsynchronizer however,
    so handle that like EOS and force out any remaining text then.

    https://bugzilla.gnome.org/show_bug.cgi?id=771853

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.