[Bug 792189] srt: add recipe

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792189

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367279|none                        |needs-work
             status|                            |

--- Comment #12 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 367279:
 --> (https://bugzilla.gnome.org/review?bug=792189&attachment=367279)

::: recipes/srt.recipe
@@ +31,2 @@
         if self.config.target_platform == Platform.ANDROID:
+            self.configure_options += ' -DANDROID_NDK=1 '

I'm not convinced we should treat the Android NDK in a special one, there is
nothign android specific in here.

::: recipes/srt/0001-Build-support-for-Android-in-cerbero.patch
@@ +19,3 @@
++if (ANDROID_NDK)
++    pkg_check_modules (GNUSTL REQUIRED "gnustl")
++endif()

I suggest just putting this part in the recipe file as it's so cerbero
specific.

@@ +29,3 @@
+ endif()
+ 
++if (NOT ANDROID_NDK)

This not not android specific. I think it should just use the following unless
some manual variable is specified.. And this should be upstreamed to srt:

set(THREADS_PREFER_PTHREAD_FLAG ON)
find_package(Threads REQUIRED)

@@ +48,3 @@
+-add_library(${TARGET_srt} ${srt_libspec} ${SOURCES_srt} ${SOURCES_srt_extra})
++add_library(${TARGET_srt} SHARED ${SOURCES_srt} ${SOURCES_srt_extra})
++add_library(${TARGET_srt}_static STATIC ${SOURCES_srt} ${SOURCES_srt_extra})

Here, I'd really like to be able to build both static and shared in one go in a
way that can be upstreamed.. Maybe with a ENABLE_BOTH or something similar. Sad
that CMake doesn't help us there.

@@ +81,3 @@
++if ( LINUX AND NOT ANDROID_NDK )
+     target_link_libraries(${TARGET_srt} PUBLIC rt)
+     set (IFNEEDED_SRT_LDFLAGS -pthread)

After discussion with Mikolaj on their Slack, we can just remove the check
entirely. No function from librt are used now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.