[Bug 792983] New: gst-plugins-base 1.12 fails to read UTF-8 encoded id3v2 tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792983

            Bug ID: 792983
           Summary: gst-plugins-base 1.12 fails to read UTF-8 encoded
                    id3v2 tags
    Classification: Platform
           Product: GStreamer
           Version: 1.12.x
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: caneko at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 367542
  --> https://bugzilla.gnome.org/attachment.cgi?id=367542&action=edit
5 seconds of silence MP3 file with ID3v2.4 tags edited with EasyTag

With gst-plugins-base 1.12, UTF-8 encoded id3v2.4 tags in MP3 files are marked
as broken and ignored. This causes Totem to only display the filename instead
of any metadata in the id3v2 tags, and Rhythmbox to import a music file without
any meaningful information. The error does not occur in gst-plugins-base 1.10.
This happens with an MP3 with id3v2 tags edited using EasyTag 2.4.3 using UTF-8
as character encoding.

The problem seems to be in gst-libs/gst/tag/id3v2.c, the logs for totem show
the messages:

0:00:00.224698317  4663 0x7fad4013d1e0 DEBUG                  id3v2
id3v2.c:230:gst_tag_list_from_id3v2_tag: Reading ID3v2 tag with revision 2.4.0
of size 1024
0:00:00.224703489  4663 0x7fad4013d1e0 DEBUG                  id3v2
id3v2.c:591:id3v2_frames_to_tag_list: Could not extract any frames from tag.
Broken or empty tag
0:00:00.224706673  4663 0x7fad4013d1e0 LOG               GST_BUFFER
gstbuffer.c:1582:gst_buffer_resize_range: trim 0x5615cb264b30 0-4096 size:1024
offs:0 max:4103
0:00:00.224711225  4663 0x7fad4013d1e0 WARN                tagdemux
gsttagdemux.c:1264:gst_tag_demux_pull_start_tag:<id3demux0> Ignoring broken
start tag of size 1024

As an exercise I used id3v2.c and id3v2.h from gst-plugins-base 1.10.5 in
1.12.3; the problem disappears after installing this version.

If EasyTag is generating invalid id3v2 tags, it has been doing it for the last
four years.

I attach a dummy MP3 test file of 5 seconds of silence with id3v2 tags edited
with EasyTag, and the GST_DEBUG=6 logs of reproducing it with Totem.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.