[Bug 792043] include all OMX extension headers if present

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792043

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #366076|none                        |reviewed
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 366076:
 --> (https://bugzilla.gnome.org/review?bug=792043&attachment=366076)

Looks correct, even though I think the way the meson script is made is not
nice.

::: meson.build
@@ +298,3 @@
+if have_core_ext
+  cdata.set ('HAVE_CORE_EXT', 1)
+endif

Why such an expansion ? (I guess was there before though).

if (cc.has_header ('my.h', args: gst_omx_args, requires: false)
  cdata.set ('...
endif

Would be denser and plenty readable.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.