[Bug 792043] include all OMX extension headers if present
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Jan 29 13:42:41 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=792043
--- Comment #5 from Guillaume Desmottes <gdesmott at gnome.org> ---
(In reply to Nicolas Dufresne (stormer) from comment #2)
> Review of attachment 366076 [details] [review]:
>
> Looks correct, even though I think the way the meson script is made is not
> nice.
>
> ::: meson.build
> @@ +298,3 @@
> +if have_core_ext
> + cdata.set ('HAVE_CORE_EXT', 1)
> +endif
>
> Why such an expansion ? (I guess was there before though).
Becase we actually check if those headers are present if 'have_external_omx ==
true'. If not we hardcode the ones present in our copy of the OMX headers
(hence the have_*_ext = true/false initialization).
One option could be to change the logic to always detect which files are
present (whether using external OMX headers or not).
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list