[Bug 792528] gst-omx: add properties for the Zynqultrascaleplus

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792528

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #366814|none                        |needs-work
             status|                            |

--- Comment #20 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 366814:
 --> (https://bugzilla.gnome.org/review?bug=792528&attachment=366814)

::: omx/gstomxvideodec.c
@@ +86,3 @@
 {
+  PROP_0,
+#ifdef USE_OMX_TARGET_ZYNQ_USCALE_PLUS

No need for ifdef here, it armless to always define in this private enum.

@@ +103,3 @@
     GST_TYPE_VIDEO_DECODER, DEBUG_INIT);

+#ifdef USE_OMX_TARGET_ZYNQ_USCALE_PLUS

I'f move the ifdef inside, and keep per target properties outside.

@@ +146,2 @@
   gobject_class->finalize = gst_omx_video_dec_finalize;
+#ifdef USE_OMX_TARGET_ZYNQ_USCALE_PLUS

Move the ifdef after.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.