[Bug 793008] buffer: add GST_BUFFER_FLAG_NON_DROPPABLE

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793008

--- Comment #12 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 367644
  --> https://bugzilla.gnome.org/attachment.cgi?id=367644
gstbuffer: add GST_BUFFER_FLAG_NON_DROPPABLE

>This can be used to identify buffers that should not be dropped
>when reducing bandwidth, or for which a higher percentage of
>redundancy should be allocated when performing forward error
>correction.

I don't really understand the reference to 'when reducing bandwidth'. The
phrase comes from the DROPPABLE flag description I guess, I just don't know if
it needs to be kept around.

>diff --git a/common b/common
>index 3fa2c9e37..3f4aa969c 160000
>--- a/common
>+++ b/common
>@@ -1 +1 @@
>-Subproject commit 3fa2c9e372bceec30be91e67fb02b6cb05bed493
>+Subproject commit 3f4aa969cbe39584a649d98d4cf321d78bd73092


common submodule commit should be removed.


>+ * @GST_BUFFER_FLAG_NON_DROPPABLE: the buffer can not be dropped without breaking the
>+ *         stream, for example to reduce bandwidth.


I would remove the "for example to reduce bandwidth" bit here.

How about "This buffer is important and should not be dropped. This can be used
to mark important buffers, e.g. to flag RTP packets carrying keyframes or codec
setup data for RTP Forward Error Correction purposes, or to prevent still video
frames from being dropped by elements due to QoS."

Or is this too much detail?

Also let's add a "(Since: 1.14)" at the end of the description line.

Lastly, should we move up the @NON_DROPPABLE in the docs chunk to be next to
the DROPPABLE one?

In any case, I think this is good to go in.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.