[Bug 796705] [gstreamer-vaapi][jpegenc] Encoding JPEG will result in green/black display encoded output

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796705

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372862|none                        |needs-work
             status|                            |

--- Comment #3 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 372862:
 --> (https://bugzilla.gnome.org/review?bug=796705&attachment=372862)

Overall it looks good.

Just a couple nitpicks:

1. The commit log format: the subject, if possible, should be 50 chars long,
with prefix "libs: encoder: jpeg: ..." 
2. Wrap the body to 72 chars

https://chris.beams.io/posts/git-commit/#seven-rules

In my opinion is important to remark the importance of the patch regardless the
va backend, setting the component id and Tqi

::: gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c
@@ +229,3 @@
+    pic_param->component_id[i] = i + 1;
+    if (i == 0)
+      pic_param->quantiser_table_selector[i] = 0;

There is no need to set zero, since the structure is already set to zero.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.