[Bug 796705] [gstreamer-vaapi][jpegenc] Encoding JPEG will result in green/black display encoded output

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796705

--- Comment #5 from Tianhao <tianhao.liu at intel.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #3)
> Review of attachment 372862 [details] [review]:
> 
> Overall it looks good.
> 
> Just a couple nitpicks:
> 
> 1. The commit log format: the subject, if possible, should be 50 chars long,
> with prefix "libs: encoder: jpeg: ..." 
> 2. Wrap the body to 72 chars
> 
> https://chris.beams.io/posts/git-commit/#seven-rules
> 
> In my opinion is important to remark the importance of the patch regardless
> the va backend, setting the component id and Tqi
> 
> ::: gst-libs/gst/vaapi/gstvaapiencoder_jpeg.c
> @@ +229,3 @@
> +    pic_param->component_id[i] = i + 1;
> +    if (i == 0)
> +      pic_param->quantiser_table_selector[i] = 0;
> 
> There is no need to set zero, since the structure is already set to zero.

Thanks for your review, I'll write a good message and submit a new patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.