[Bug 796731] gstplayer join to self cause crash

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796731

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372907|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 372907:
 --> (https://bugzilla.gnome.org/review?bug=796731&attachment=372907)

::: gst-libs/gst/player/gstplayer.c
@@ +493,3 @@
     g_main_loop_quit (self->loop);
+    if (self->thread != g_thread_self ())
+      g_thread_join (self->thread);

If you don't join, you need to call g_thread_unref() instead. Seems to be the
best we can do here

However it's suboptimal that the last reference is dropped from here, ideally
your application should have the last reference in the end

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.