[Bug 795891] matroskademux: emits invalid Pango markup

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795891

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372898|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 372898:
 --> (https://bugzilla.gnome.org/review?bug=795891&attachment=372898)

::: gst/matroska/matroska-demux.c
@@ +2315,3 @@
+  keyunit = !!(flags & GST_SEEK_FLAG_KEY_UNIT);
+  after = !!(flags & GST_SEEK_FLAG_SNAP_AFTER);
+  before = !!(flags & GST_SEEK_FLAG_SNAP_BEFORE);

Irrelevant changes, please put into a separate commit (just push it, no need
for review) :)

@@ +3400,3 @@
       utf8 = g_markup_escape_text ((gchar *) map.data, map.size);

+      /* FIXME: WebVTT support */

What does this mean? Will WebVTT work correctly but it is just not sanitized?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.