[Bug 795891] matroskademux: emits invalid Pango markup
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Jul 2 13:25:14 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=795891
--- Comment #17 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
I think neither the naming nor the way this works is ideal yet :)
How does it work? Does it modify (and replace, if needed) an existing string in
place?
I dislike the _subrip() specific thing and also the is_webvtt boolean.
Could we do this as a generic function? (e.g. passing in a format enum with a
flags field or something if needed)
How about we pass a string in, function takes ownership and we return a new
string? (Which may be the old one or not?)
What about error handling? Are there cases where we should/need to return an
error or a warning?
OR MAYBE we should just do this all differently, and force subparse to be
plugged in this case via an extra caps field, and let subparse clean it up?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list