[Bug 796718] avmux_ivf: Add VP9 and AV1 sink capabilities

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796718

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372876|none                        |reviewed
             status|                            |

--- Comment #3 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 372876:
 --> (https://bugzilla.gnome.org/review?bug=796718&attachment=372876)

::: ext/libav/gstavcodecmap.c
@@ +3691,3 @@
       AV_CODEC_ID_ADPCM_YAMAHA, AV_CODEC_ID_NONE
     };
+

spurious new line (not related with the purpose of this patch)

@@ +3699,3 @@
       AV_CODEC_ID_NONE
     };
+

ditto

@@ +3708,3 @@
     *video_codec_list = gif_image_list;
     *audio_codec_list = NULL;
+  } else if (!strcmp (format_name, "pva")) {

this pva fix should be move into a different patch, following the spirit of
atomic patches and readability.

@@ +3764,3 @@
   mimetype = gst_structure_get_name (structure);

+  GST_LOG ("mimetype: %s", mimetype);

I think this log message is not needed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.