[Bug 792825] rtph264pay: add support for STAP-A bundling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792825

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372885|none                        |needs-work
             status|                            |

--- Comment #13 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 372885:
 --> (https://bugzilla.gnome.org/review?bug=792825&attachment=372885)

::: gst/rtp/gstrtph264pay.c
@@ +1088,3 @@
+    GST_WRITE_UINT16_BE (size_header, gst_buffer_get_size (buf));
+    gst_buffer_append_memory (outbuf,
+        gst_memory_new_wrapped (0, size_header, 2, 0, 2, size_header,
g_free));

Just use gst_memory_new_allocate() instead, you'll have one allocation instead
of 2.

@@ +1127,3 @@
+    if (ret != GST_FLOW_OK)
+      goto out;
+  }

You may also want to send the bundle if the timestamp changes. The AUD is only
present in byte-stream mode, but generally not in AVC1/3 modes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.