[Bug 796692] sample/bufferlist/buffer: Non-writable container miniobjects allow writable access to their contents, causing memory problems

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796692

--- Comment #35 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Sebastian Dröge (slomo) from comment #34)
> Created attachment 372952 [details] [review]
> bufferlist: Prevent gst_buffer_list_foreach() from modifying non-writeable
> lists
> 
> Previously gst_buffer_list_foreach() could modify (drop or replace)
> buffers in non-writable lists, which could cause all kinds of problems
> if other code also has a reference to the list and assumes that it stays
> the same.

This is a different bug from everything else in this ticket and also existed
since forever, but on top of the other changes it is easier to fix (because we
already have another reference to buffers in non-writable lists anyway and
don't have to save them from the callback destroying them).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.