[Bug 796692] sample/bufferlist/buffer: Non-writable container miniobjects allow writable access to their contents, causing memory problems

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796692

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372952|none                        |accepted-commit_now
             status|                            |

--- Comment #40 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 372952:
 --> (https://bugzilla.gnome.org/review?bug=796692&attachment=372952)

Looks good

::: gst/gstbufferlist.c
@@ +271,3 @@
      */
     was_writable = gst_buffer_is_writable (buf);
+    if (was_writable && list_was_writable)

Ah, this implements one of the comments I made on the initial patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.