[Bug 783521] gl: Add "direct" dmabuf uploader
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Jul 6 09:25:18 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=783521
--- Comment #29 from Michael Olbrich <m.olbrich at pengutronix.de> ---
About the g_return_val_if_fail patches in gst_gl_memory_setup_buffer() (for
some reason, reviewing patches does not work for me):
For views == 1 i think n_mem == n_wrapped_pointers is the correct check.
I don't know how multi-view should work here, however with this code:
for (v = 0; v < views; v++) {
for (i = 0; i < n_mem; i++) {
[...]
... = wrapped_data[i];
[...]
"n_mem * views == n_wrapped_pointers" seems wrong. Only n_mem wrapped pointers
are used, regardless of the number of views. Is the code incorrect or the
check?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list