[Bug 783521] gl: Add "direct" dmabuf uploader

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783521

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372960|none                        |reviewed
             status|                            |

--- Comment #31 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 372960:
 --> (https://bugzilla.gnome.org/review?bug=783521&attachment=372960)

Looks mostly ok.

::: gst-libs/gst/gl/gstglupload.c
@@ +1771,3 @@
+  if (upload->priv->method_i == 0) {
+    upload->priv->method_i = upload->priv->saved_method_i;
+    upload->priv->saved_method_i = 0;

Maybe a comment here that this is only really used for reconfiguration and
set_caps() will reset upload->priv->method_i to 0 so we need to reset it after
a reconfiguration.

@@ +1868,3 @@

+  if (ret == GST_GL_UPLOAD_RECONFIGURE && upload->priv->method_i > 0)
+    upload->priv->saved_method_i = upload->priv->method_i - 1;

Any particular reason why this wasn't put into the above if statement with all
the other ret checking?

Also, this assumes that the first method will never need a reconfigure.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.