[Bug 783521] gl: Add "direct" dmabuf uploader

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783521

--- Comment #35 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
(In reply to Michael Olbrich from comment #29)
> About the g_return_val_if_fail patches in gst_gl_memory_setup_buffer() (for
> some reason, reviewing patches does not work for me):
> 
> For views == 1 i think n_mem == n_wrapped_pointers is the correct check.
> I don't know how multi-view should work here, however with this code:
> 
>   for (v = 0; v < views; v++) { 
>     for (i = 0; i < n_mem; i++) {
> [...]
>       ... = wrapped_data[i];
> [...]
> 
> "n_mem * views == n_wrapped_pointers" seems wrong. Only n_mem wrapped
> pointers are used, regardless of the number of views. Is the code incorrect
> or the check?

hrm I think the code is wrong for separated mode.  If separated, there are
n_views * n_planes number of memories that need to be used.  For non-separated
mode, there are only ever n_planes number of memories.  The index into
wrapped_data should be wrapped_data[v * n_mem + i].  Evidently no-one's ever
uploaded separated multiview buffers from external memory :).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.