[Bug 796647] qtdemux: PIFF track encryption box support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796647

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372757|none                        |reviewed
             status|                            |

--- Comment #2 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 372757:
 --> (https://bugzilla.gnome.org/review?bug=796647&attachment=372757)

Looks generally correct.

::: gst/isomp4/qtdemux.c
@@ +10050,3 @@
+      }
+      tenc_data = (const guint8 *) tenc->data + 12;
+      isEncrypted = QT_UINT24 (tenc_data);

Should have been is_encrypted, not your fault though.

@@ +10076,3 @@
+        return FALSE;
+      }
+      tenc_data = (const guint8 *) tenc->data + 16 + 12;

Are we garanteed we have enough data here? I do not have the impression

@@ +10084,3 @@
+        isEncrypted = FALSE;
+      } else if (algorithm_id == 1) {
+        /* FIXME: maybe store this in properties? */

We probably want to add the info somewhere/in ss_info->default_properties?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.