[Bug 796519] Add AV1 codec parser

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jul 10 13:26:07 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796519

--- Comment #10 from Georg Ottinger <g.ottinger at gmx.at> ---
(In reply to sreerenj from comment #5)
> All of the other codecparser APIs(h264, vp9 etc) accept a pointer to
> data(which needs to be parsed) as the input argument of APIs, why av1parser
> designed to accept BitReader instead of raw data?
> This is asking the user to deal with BitReader in order to invoke the
> parsing APIs which is not an ideal way IMHO.

When coding the test case for me it seemed the more straight forward way to use
Bitreader as an argument - cause I am dealing here with a Stream of different
OBUs with variable sizes. The VP9 codecparser exposes one parsing function
(frame_header), AV1 has to deal with a number of differen OBUs (frame,
frame_header, tile_group, sequence, metadata, tile_list). BitReader comes in
handy, cause it is taking care about the bit-position accounting. If I change
the interface to "const guint *data, gsize size" - I will loose the information
how many bits/bytes were actually processed and handle this one layer above. 

That said I have no objections to change the interface as suggested.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list